Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid '^triedb layer .+ is disk layer$' error #2588

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

diegoximenes
Copy link
Contributor

@diegoximenes diegoximenes commented Aug 19, 2024

Avoids triedb layer [0x0e552df5239ed990b07bcc41519355c432e443bea4b3d3822adb9b136107e585] is disk layer error in InitializeArbosInDatabase when using PathScheme.

pathdb returns an error when there are no state trie changes to commit and we try to commit.
Later I will create a PR in https://github.com/ethereum/go-ethereum to return nil instead.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Aug 19, 2024
@diegoximenes diegoximenes marked this pull request as ready for review August 19, 2024 12:44
tsahee
tsahee previously approved these changes Aug 19, 2024
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegoximenes diegoximenes merged commit 5997c16 into master Aug 19, 2024
13 checks passed
@diegoximenes diegoximenes deleted the fix_path_layer_is_disk branch August 19, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants